Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: 21 April 2025 15:02 > Subject: Re: [PATCH net-next v5 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH > > > > On the RZ/G3E, the upstream support for testing S2R is not yet in a > > > usable state. So for now, I'll switch to using init/exit callbacks and drop the PM callback. > > > > FYI, On RZ/G3E, for STR to work with mainline, we need to reinitialize the PHY. > > I have done below changes on top of [1] to make STR working. > > Can you explain why you need to reinitialise the PHY? The MAC driver should not need to do this, so > something is wrong somewhere. If we understand the 'Why?' we can probably tell you a better way to do > this. Without this change bind/unbind works. But for the STR case, without reinitializing the PHY, even though the IP link is UP, I am not able to talk the NFS server or ping the host properly. I checked clock/reset before and after reset everything set as expected. Only change during STR is, on wakeup we need to restore direction (MII/RGMII) of IO block for ET0/1_TXC_TXCLK (IO attribute) in the pin control driver. After that looks like PHY init is required to talk to server. Cheers, Biju
