Hi Thierry,
On Thu, 3 Apr 2025 at 23:29, Thierry Bultel
<thierry.bultel.yh@xxxxxxxxxxxxxx> wrote:
> RSCI of RZ/T2H SoC (a.k.a r9a09g077), as a lot
> of similarities with SCI in other Renesas SoC like G2L, G3S, V2L;
> However, it has a different set of registers, and in addition to serial,
> this IP also supports SCIe (encoder), SmartCard, i2c and spi.
> This is why the 'renesas,sci' fallback for generic SCI does not apply for it.
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: Thierry Bultel <thierry.bultel.yh@xxxxxxxxxxxxxx>
> ---
> Changes v6->v7:
> - Moved all rsci in a separate file
> - Added example
Thanks for your patch, which is now commit 25422e8f46c1fd14
("dt-bindings: serial: Add compatible for Renesas RZ/T2H SoC in sci")
in tty/tty-next.
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/renesas,rsci.yaml
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> +
> + aliases {
> + serial0 = &sci0;
> + };
Aliases are not really needed in examples; the DT janitors may send
a patch to remove this ;-).
> +
> + sci0: serial@80005000 {
> + compatible = "renesas,r9a09g077-rsci";
> + reg = <0x80005000 0x400>;
> + interrupts = <GIC_SPI 590 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 591 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 592 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 593 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "eri", "rxi", "txi", "tei";
> + clocks = <&cpg CPG_MOD 108>;
Shouldn't that be 8 instead of 108?
Doesn't matter much, as this file is just an example...
> + clock-names = "fck";
> + power-domains = <&cpg>;
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
