Re: [PATCH v2] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe Debug LEDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Thu, 17 Apr 2025 at 10:52, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Because these LEDs are not connected to a device and have only a single
> color, we don't need to specify 'color' and 'function' to distinguish
> them. Even worse, that would lead to namespace collisions:
>
> leds-gpio leds: Led green:programming renamed to green:programming_1 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_2 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_3 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_4 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_5 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_6 due to name collision
> leds-gpio leds: Led green:programming renamed to green:programming_7 due to name collision
>
> So, just let their node name (taken from the schematics) be used as a
> name.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changes since v1:
>         * renamed nodes to match schematics
>         * added default-state
>         * updated commit message why not more LED properties are used

Thanks for the update!

You could still add the color properties without function properties.
However, the "function-enumerator" property exists to avoid the collisions.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux