On Tue, Apr 15, 2025 at 01:56:41PM +0100, Prabhakar wrote: > Add the DWMAC glue layer for the GBETH IP found in the Renesas RZ/V2H(P) > SoC. I think we're almost there, but now that the trees have parted, we can start seeing other bits of wood :) > +struct renesas_gbeth { > + struct plat_stmmacenet_data *plat_dat; > + struct reset_control *rstc; > + struct device *dev; > + void __iomem *regs; This appears to be only written, never read. Do you need it? I think that's the last thing I can spot in this driver, so with that fixed, please add: Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!