Hi Krzysztof,
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 15 April 2025 10:40
> Subject: Re: [PATCH v4 8/9] memory: renesas-rpc-if: Add RZ/G3E xSPI support
>
> On 15/04/2025 10:18, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >> Sent: 15 April 2025 07:17
> >> Subject: Re: [PATCH v4 8/9] memory: renesas-rpc-if: Add RZ/G3E xSPI
> >> support
> >>
> >> On 01/04/2025 16:35, Biju Das wrote:
> >>> int rpcif_manual_xfer(struct device *dev) {
> >>> struct rpcif_priv *rpc = dev_get_drvdata(dev); @@ -493,7 +769,7 @@
> >>> int rpcif_manual_xfer(struct device *dev)
> >>> if (ret)
> >>> return ret;
> >>>
> >>> - ret = rpcif_manual_xfer_impl(rpc);
> >>> + ret = rpc->info->impl->manual_xfer(rpc);
> >>>
> >>> pm_runtime_put(dev);
> >>>
> >>> @@ -543,6 +819,61 @@ static void memcpy_fromio_readw(void *to,
> >>> }
> >>> }
> >>>
> >>
> >> Missing kerneldoc. Exported functions shoud have kerneldoc.
> >
> > Currently there is no exported function in this driver have kernel doc.
>
> I know. My comment was about new code.
OK. Then I will update the patch for new code.
Later will add for the rest of the functions.
Cheers,
Biju
>
> > I will add a separate patch for fixing that as well.
>
>
> Best regards,
> Krzysztof
