Hi Krzysztof Kozlowski, Thanks for the feedback. + clk > -----Original Message----- > From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > Sent: 15 April 2025 07:03 > Subject: Re: [PATCH v4 1/9] dt-bindings: memory: Document RZ/G3E support > > On 01/04/2025 16:35, Biju Das wrote: > > diff --git a/include/dt-bindings/clock/renesas,r9a09g047-cpg.h > > b/include/dt-bindings/clock/renesas,r9a09g047-cpg.h > > index 1d031bf6bf03..98df165579e1 100644 > > --- a/include/dt-bindings/clock/renesas,r9a09g047-cpg.h > > +++ b/include/dt-bindings/clock/renesas,r9a09g047-cpg.h > > @@ -17,5 +17,6 @@ > > #define R9A09G047_CM33_CLK0 6 > > #define R9A09G047_CST_0_SWCLKTCK 7 > > #define R9A09G047_IOTOP_0_SHCLK 8 > > +#define R9A09G047_SPI_CLK_SPI 9 > > That's not really a related change. Clock is there regardless whether you implement or not implement > SPI. Putting this here makes it just conflict-prone and adds a need for Ack. OK, I will make this as separate patch, so that it goes through Clock subsystem merging with [1] [1] https://lore.kernel.org/all/20250408113845.130950-2-biju.das.jz@xxxxxxxxxxxxxx/ Cheers, Biju > > > > > #endif /* __DT_BINDINGS_CLOCK_RENESAS_R9A09G047_CPG_H__ */ > > > Best regards, > Krzysztof