Hi Niklas,
On Sat, 15 Mar 2025 at 16:28, Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> All ISP instances on V3U have both a channel select and core function
> block, describe the core region in addition to the existing cs region.
>
> The interrupt number already described intended to reflect the cs
> function but did incorrectly describe the core block. This was not
> noticed until now as the driver do not make use of the interrupt for the
> cs block.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -2588,13 +2588,20 @@ du_out_dsi1: endpoint {
> isp0: isp@fed00000 {
> compatible = "renesas,r8a779a0-isp",
> "renesas,rcar-gen4-isp";
> - reg = <0 0xfed00000 0 0x10000>;
> - interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 612>;
> + reg = <0 0xfed00000 0 0x10000>, <0 0xfec00000 0 0x100000>;
> + reg-names = "cs", "core";
> + interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>;
So we used to describe the "wrong" interrupt before, but it didn't hurt,
as the driver doesn't use it anyway?
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Queuing in renesas-devel is postponed, pending acceptance of the DT
binding changes.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
