On Thu, Apr 10, 2025 at 09:11:22AM -0500, Rob Herring wrote: > On Fri, Apr 4, 2025 at 9:56 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote: > > > > > > On Thu, 03 Apr 2025 21:59:35 -0500, Rob Herring (Arm) wrote: > > > Replace the prose for properties dependent on specific "enable-method" > > > values with schemas defining the same requirements. > > > > > > Both "qcom,acc" and "qcom,saw" properties appear to be required for any > > > of the Qualcomm enable-method values, so the schema is a bit simpler > > > than what the text said. The references to arm/msm/qcom,saw2.txt and > > > arm/msm/qcom,kpss-acc.txt are out of date, so just drop them. > > > > > > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/arm/cpus.yaml | 82 +++++++++++++++---------- > > > 1 file changed, 49 insertions(+), 33 deletions(-) > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,saw2.example.dtb: cpu@0: 'qcom,acc' is a required property > > from schema $id: http://devicetree.org/schemas/arm/cpus.yaml# > > Any Qcom folks want to tell me whether both qcom,acc and qcom,saw are > required or not? All the actual users have both. Yes, as far as I remember. -- With best wishes Dmitry
