On 10/04/2025 01:25, Kuninori Morimoto wrote:
>
> Hi Krzysztof, Mark, Iwai-san
>
>>> + dev_info(dev, "probed\n");
>>
>> Drop. Driver should be silent on success and simple success messages are
>> useless. Core already gives you information that probe succeeded.
>
> What does "Core" mean here ??
Core of Linux.
>
>>> +MODULE_ALIAS("platform:msiof-pcm-audio");
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it,
>> usually it means your device ID table is wrong (e.g. misses either
>> entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
>> for incomplete ID table.
>
> Iwai-san, Mark, do you have any comment about this ?
> Almost all ALSA drivers are using it
>
> > git grep MODULE_ALIAS sound | wc -l
> 249
What do you need it for? You already have ID table.
Just because drivers need it, is not a justification that you need. If
other drivers have poor code, it's okay to do the same?
Best regards,
Krzysztof
