Hi Krzysztof > Yes, probably. Although missing cells is easy to change but missing > protocol, like this patchset here, is quite more challenging. MSIOF-I2S is using MSIOF-SPI's property, these are compatible. The diff is I2S is using Of-Graph, SPI is not. Not so challenging ? > > > +properties: > > > + compatible: > > > + items: > > > + - const: renesas,msiof-r8a779g0 # R-Car V4H > > > > > > Use expected format of all soc compatibles. It has been always: SoC-module. > > ... unless this is an existing compatible, but then it should be in one > schema, not two. If I merged MSIOF-I2S/SPI into one, Of-Graph part will be option ? >> where to fit it in the DT binding doc hierarchy? > > Does not matter, whatever fits better in overal picture/purpose of this > device. Can I put info like linux/Documentation/devicetree/bindings/sound/renesas,msiof.txt --- renesas,msiof.txt --- MSIOF-I2S and MSIOF-SPI are using same DT schema. See linux/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml ------------------------- Thank you for your help !! Best regards --- Kuninori Morimoto