Hi Geert Thank you for your review > > Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as > > both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which > > Of-Graph in DT. > > > > MSIOF-SPI/I2S are using same DT compatible properties. > > MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, > > MSIOF-SPI doesn't use Of-Graph. > > > > Check "port" node when driver probing > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks > > @@ -1276,10 +1277,19 @@ static int sh_msiof_spi_probe(struct platform_device *pdev) > > const struct sh_msiof_chipdata *chipdata; > > struct sh_msiof_spi_info *info; > > struct sh_msiof_spi_priv *p; > > + struct device_node *port; > > If you would add "__free(device_node)", you could drop the of_node_put() > below. Yes, indeed. will use it in v2 > > + /* Check whether MSIOF is used as I2S mode or SPI mode by checking "port" node */ > > + port = of_graph_get_next_port(pdev->dev.of_node, NULL); > > This is actually checking for both "ports" and "port". If you know the > subnode is called "port", you could simplify to of_get_child_by_name(). Current dt-bindings Doc is caring only "port" for now (because it will be more complicated if care both...), but sound might/can use "ports". Thank you for your help !! Best regards --- Kuninori Morimoto
