On 18/03/2025 03:06, Kuninori Morimoto wrote: > Renesas MSIOF (Clock-Synchronized Serial Interface with FIFO) can work as > both SPI and I2S. MSIOF-I2S will use Audio Graph Card/Card2 driver which > uses Of-Graph in DT. > > MSIOF-SPI/I2S are using same DT compatible properties. > MSIOF-I2S uses Of-Graph for Audio-Graph-Card/Card2, > MSIOF-SPI doesn't use Of-Graph. > > Ignore MSIOF-I2S case (= Of-Graph) in MSIOF-SPI Doc. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Missing dt-bindings. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > --- > .../devicetree/bindings/spi/renesas,sh-msiof.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > index 49649fc3f95a..c491ef5bc78c 100644 > --- a/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > +++ b/Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml > @@ -9,6 +9,18 @@ title: Renesas MSIOF SPI controller > maintainers: > - Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > +# sharing with MSIOF I2S That's not how you create common schemas. You need to separate schema which is then referenced with $ref with all users. > +# see > +# ${LINUX}/Documentation/devicetree/bindings/sound/renesas,msiof.yaml In anycase drop ${linux}, so the path is verifiable.... which leads to problem: I do not see that file in next. > +select: > + properties: > + compatible: > + contains: > + pattern: "^renesas,.*-msiof$" You don't get custom selects. This replaces existing select which breaks the binding. Best regards, Krzysztof
