Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 31 March 2025 13:52
> Subject: Re: [PATCH v3 8/9] memory: renesas-rpc-if: Add RZ/G3E xSPI support
>
> Hi Biju,
>
> On Tue, 11 Mar 2025 at 12:36, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add support for RZ/G3E xSPI. Compared to RPC-IF, it can support writes
> > on memory-mapped area.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/memory/renesas-rpc-if.c
> > +++ b/drivers/memory/renesas-rpc-if.c
> > @@ -49,6 +59,8 @@ struct rpcif_priv {
> > enum rpcif_data_dir dir;
> > u8 bus_size;
> > u8 xfer_size;
> > + u8 addr_nbytes;
>
> Please add a comment, as this is used only on xSPI, just like the member below.
OK.
>
> > + u32 proto; /* Specified for xSPI */
> > void *buffer;
> > u32 xferlen;
> > u32 smcr;
>
> > @@ -240,7 +307,10 @@ int rpcif_hw_init(struct device *dev, bool hyperflash)
> > if (ret)
> > return ret;
> >
> > - ret = rpcif_hw_init_helper(rpc, hyperflash);
> > + if (rpc->info->type == XSPI_RZ_G3E)
> > + ret = xspi_hw_init(rpc);
> > + else
> > + ret = rpcif_hw_init_helper(rpc, hyperflash);
>
> I think it would be cleaner if you would call all actual implementations through a function pointer
> table in rpcif_info.
Agreed, will fix this in next version.
Cheers,
Biju
