On Mon, 31 Mar 2025 at 14:05, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Tue, 11 Mar 2025 at 12:36, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Fix the below macro error found while moving the reg definitions
> > to renesas-rpc-if-regs.h in the later patch.
> >
> > ERROR: Macros with complex values should be enclosed in parentheses
> > #define RPCIF_DRENR_CDB(o) (u32)((((o) & 0x3) << 30))
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/memory/renesas-rpc-if.c
> > +++ b/drivers/memory/renesas-rpc-if.c
> > @@ -56,7 +56,7 @@
> > #define RPCIF_DROPR 0x0018 /* R/W */
> >
> > #define RPCIF_DRENR 0x001C /* R/W */
> > -#define RPCIF_DRENR_CDB(o) (u32)((((o) & 0x3) << 30))
> > +#define RPCIF_DRENR_CDB(o) (((u32)((o) & 0x3) << 30))
>
> The most-outer sets of parentheses are duplicated.
I meant: The most outer set of parentheses is duplicated.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
