Hi Marek
Thank you for the patch
> Add Renesas R-Car V4H Sparrow Hawk board based on R-Car V4H ES3.0 (R8A779G3)
> SoC. This is a single-board computer with single gigabit ethernet, DSI-to-eDP
> bridge, DSI and two CSI2 interfaces, audio codec, two CANFD ports, micro SD
> card slot, USB PD supply, USB 3.0 ports, M.2 Key-M slot for NVMe SSD, debug
> UART and JTAG.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
Not all parts, but for my related part only
Tested-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
One concern from my side is
> + /* Page 31 / FAN */
> + fan: pwm-fan {
> + pinctrl-0 = <&irq4_pins>;
> + pinctrl-names = "default";
> + compatible = "pwm-fan";
> + #cooling-cells = <2>;
> + cooling-levels = <0 50 100 150 200 255>;
> + pwms = <&pwm0 0 50000>;
> + pulses-per-revolution = <2>;
> + interrupts-extended = <&intc_ex 4 IRQ_TYPE_EDGE_FALLING>;
> + /* No FAN connected by default. */
> + status = "disabled";
> + };
Indeed "base kit" doesn't have FAN, but "complete kit" will have, and
official page/site will recommend to buy and use it because the board will
be very hot. Default "enable" is better idea, IMO.
But it is not a big deal for now. Additional patch instead of v2 is OK for me.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
