Hi Matti, The new helpers for ADC drivers look good to me. I am now very late to complain about anything but am leaving some minor comments below that can be completely ignored. Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx> Thanks, Marcelo On 03/24, Matti Vaittinen wrote: > There are ADC ICs which may have some of the AIN pins usable for other > functions. These ICs may have some of the AIN pins wired so that they > should not be used for ADC. > > (Preferred?) way for marking pins which can be used as ADC inputs is to > add corresponding channels@N nodes in the device tree as described in > the ADC binding yaml. Not sure it's preferred to have ADC channels always declared in dt. That question was somewhat also raised during ADC doc review [1]. In short, ADC channel may and may not be declared under ADC dt node. ADC bindings often don't enforce channels to be declared. On IIO side of things, many ADC drivers just populate channels even if they are not declared in dt. The ADCs you are supporting in the other patches of this series seem to require dt declared channels though. [1]: https://lore.kernel.org/linux-iio/20250118155153.2574dbe5@jic23-huawei/ Would something like A common way of marking pins that can be used as ADC inputs is to add corresponding channel@N nodes in the device tree as described in the ADC binding yaml. be a good rephrasing of the above paragraph? > > Add couple of helper functions which can be used to retrieve the channel > information from the device node. > > Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > ... > +static inline int iio_adc_device_num_channels(struct device *dev) > +{ > + return device_get_named_child_node_count(dev, "channel"); > +} I wonder if this function name can eventually become misleading. In Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml we have temperature sensor with channel nodes named after external hardware connected to the sensor, leading to channels having different node names. Can anything like that ever be accepted for ADC bindings?
