On 28/03/2025 at 18:02, Biju Das wrote: > Hi Vincent, > >> -----Original Message----- >> From: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> >> Sent: 28 March 2025 08:54 >> Subject: Re: [PATCH v7 04/18] can: rcar_canfd: Drop RCANFD_GAFLCFG_GETRNC macro >> >> On 26/03/2025 at 21:19, Biju Das wrote: >>> Drop the unused macro RCANFD_GAFLCFG_GETRNC. >>> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> >>> --- >>> v6->v7: >>> * No change. >>> v5->v6: >>> * Collected tag. >>> v5: >>> * New patch >>> --- >>> drivers/net/can/rcar/rcar_canfd.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/drivers/net/can/rcar/rcar_canfd.c >>> b/drivers/net/can/rcar/rcar_canfd.c >>> index 2d9569fd0e0b..565a91c2ca83 100644 >>> --- a/drivers/net/can/rcar/rcar_canfd.c >>> +++ b/drivers/net/can/rcar/rcar_canfd.c >>> @@ -94,10 +94,6 @@ >>> (((x) & reg_gen4(gpriv, 0x1ff, 0xff)) << \ >>> (reg_gen4(gpriv, 16, 24) - ((n) & 1) * reg_gen4(gpriv, 16, 8))) >>> >>> -#define RCANFD_GAFLCFG_GETRNC(gpriv, n, x) \ >>> - (((x) >> (reg_gen4(gpriv, 16, 24) - ((n) & 1) * reg_gen4(gpriv, 16, 8))) & \ >>> - reg_gen4(gpriv, 0x1ff, 0xff)) >>> - >>> /* RSCFDnCFDGAFLECTR / RSCFDnGAFLECTR */ >>> #define RCANFD_GAFLECTR_AFLDAE BIT(8) >>> #define RCANFD_GAFLECTR_AFLPN(gpriv, x) ((x) & reg_gen4(gpriv, 0x7f, 0x1f)) >> >> >> It seems to me that there are a ton of unused macro in this module: >> >> Why are you removing just RCANFD_GAFLCFG_GETRNC an not the others? > > This macro got slipped while adding the fix [1], > > [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.14&id=1dba0a37644ed3022558165bbb5cb9bda540eaf7 > > Can I send separate patch just for dropping all unused macros listed below by adding dependency > to this series? > > Or > > You recommend v8, by updating this patch for removing all unused macros? Your series is already quite long. I am totally OK if this is done separately. Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> (...) Yours sincerely, Vincent Mailhol
