Hi Conor, On Thu, Mar 27, 2025 at 4:40 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > On Thu, Mar 27, 2025 at 11:06:33AM +0000, Lad, Prabhakar wrote: > > Hi Philipp and Conor > > > > On Thu, Mar 13, 2025 at 1:17 PM Lad, Prabhakar > > <prabhakar.csengg@xxxxxxxxx> wrote: > > > > > > Hi Philipp, > > > > > > On Thu, Mar 13, 2025 at 1:09 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > > > > > > > > On Do, 2025-03-06 at 16:26 +0000, Conor Dooley wrote: > > > > [...] > > > > > That sounds awfully like "it was wrong before, and I want to keep using > > > > > the wrong node name"... If you're claiming to be some other class of > > > > > device, "ctrl" should really be "controller" like all the other sorts of > > > > > controllers ;) > > > > > > > > There are "usb-phy-controller" nodes on the rcar-gen2 SoCs. > > > > > > > Ok, I will rename the node name to "usb-phy-controller". > > > > > Fyi to chime in with other reset drivers I'll rename this binding file > > to `renesas,rzv2h-usb2phy-reset.yaml` and have the node named > > > `usb2phy-reset@15830000` in the example node. > > At that point, isn't it then "just" a reset controller with only a > single device that it resets, so "reset-controller" is the right class > of device to label it as? I agree, I will label it as a "reset-controller". Cheers, Prabhakar
