Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: 26 March 2025 09:40 > To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>; Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>; Wolfram Sang > <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>; Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>; linux- > can@xxxxxxxxxxxxxxx; Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; biju.das.au > <biju.das.au@xxxxxxxxx>; linux-renesas-soc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 11/18] can: rcar_canfd: Add {nom,data}_bittiming variables to struct > rcar_canfd_hw_info > > On Thu, 20 Mar 2025 at 10:11, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Both R-Car Gen4 and R-Car Gen3 have different bit timing parameters > > Add {nom,data}_bittiming variables to struct rcar_canfd_hw_info to > > handle this difference. > > > > Since the mask used in the macros are max value - 1, replace that > > aswell. > > as well OK will fix this in v7. Cheers, Biju > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But when I'm talking to > journalists I just say "programmer" or something like that. > -- Linus Torvalds