Hi Krzysztof,
On Mon, 24 Mar 2025 at 13:55, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding. While re-indenting, drop
> unused labels.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -60,43 +60,34 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
>
> i2c {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - iqs620a@44 {
> - compatible = "azoteq,iqs620a";
> - reg = <0x44>;
> - interrupt-parent = <&gpio>;
> - interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> + iqs620a@44 {
> + compatible = "azoteq,iqs620a";
> + reg = <0x44>;
> + interrupt-parent = <&gpio>;
> + interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
>
> - keys {
> - compatible = "azoteq,iqs620a-keys";
> + keys {
> + compatible = "azoteq,iqs620a-keys";
>
> - linux,keycodes = <KEY_SELECT>,
> - <KEY_MENU>,
> - <KEY_OK>,
> - <KEY_MENU>;
> + linux,keycodes = <KEY_SELECT>,
> + <KEY_MENU>,
> + <KEY_OK>,
> + <KEY_MENU>;
>
> - hall-switch-south {
> - linux,code = <SW_LID>;
> - azoteq,use-prox;
> - };
> - };
> -
> - iqs620a_pwm: pwm {
> - compatible = "azoteq,iqs620a-pwm";
> - #pwm-cells = <2>;
> - };
> + hall-switch-south {
> + linux,code = <SW_LID>;
> + azoteq,use-prox;
> + };
> };
> - };
>
> - pwmleds {
> - compatible = "pwm-leds";
> -
> - led-1 {
> - pwms = <&iqs620a_pwm 0 1000000>;
> - max-brightness = <255>;
> + iqs620a_pwm: pwm {
> + compatible = "azoteq,iqs620a-pwm";
> + #pwm-cells = <2>;
> };
> + };
> };
>
> - |
The removal of the pwmleds node belongs in patch [1/2].
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
