> > Now with drm_writeback_connector moved to drm_connector it makes more
> > sense use drm_connector as an argument rather than drm_connector.
>
> than drm_writeback_connector
Sure will fix this.
>
> > The writeback connector can easily be derived from drm_connector.
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>
> > ---
> > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 2 +-
> > .../drm/arm/display/komeda/komeda_wb_connector.c | 5 +----
> > drivers/gpu/drm/arm/malidp_mw.c | 2 +-
> > drivers/gpu/drm/drm_writeback.c | 16 ++++++++--------
> > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 2 +-
> > .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 3 +--
> > drivers/gpu/drm/vc4/vc4_txp.c | 2 +-
> > drivers/gpu/drm/vkms/vkms_writeback.c | 4 ++--
> > include/drm/drm_writeback.h | 4 ++--
> > 9 files changed, 18 insertions(+), 22 deletions(-)
> >
> > @@ -338,13 +338,13 @@ static void
> drm_writeback_connector_cleanup(struct drm_device *dev,
> > * Returns: 0 on success, or a negative error code
> > */
> > int drmm_writeback_connector_init(struct drm_device *dev,
> > - struct drm_writeback_connector
> *wb_connector,
> > + struct drm_connector *connector,
> > const struct drm_connector_funcs
> *con_funcs,
> > struct drm_encoder *enc,
> > const u32 *formats, int n_formats) {
> > - struct drm_connector *connector =
> > - drm_writeback_to_connector(wb_connector);
> > + struct drm_writeback_connector *wb_connector =
> > + drm_connector_to_writeback(connector);
>
> You can use &connector->writeback without extra wrappers.
Hmm just kept it around to make abstract the internal structure, will help with future refactors if any.
Its anyways a static inline function.
If that doesn't make sense I can do it the way as you suggested and also add a patch to remove this helper altogether
Regards,
Suraj Kandpal
