Hi Wolfram, Thank for the review. On Mon, Aug 18, 2025 at 4:58 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, Aug 18, 2025 at 04:07:57PM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Correct the Mode Control Register (MODCTRL) offset for RZ/N MIIC. > > According to the R-IN Engine and Ethernet Peripherals Manual (Rev.1.30) > > [0], Table 10.1 "Ethernet Accessory Register List", MODCTRL is at offset > > 0x8, not 0x20 as previously defined. > > > > [0] https://www.renesas.com/en/document/mah/rzn1d-group-rzn1s-group-rzn1l-group-users-manual-r-engine-and-ethernet-peripherals?r=1054571 > > > > Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver") > > Cc: stable@xxxxxxxxxx > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > I can also test it on my N1D board next week. > Perfect, I dont have access to the RZ/N1 board but I'm working on reusing the same driver for a new SoC which has the same register. Cheers, Prabhakar
