Hi Russell, On Tue, Sep 2, 2025 at 10:34 AM Russell King (Oracle) <linux@xxxxxxxxxxxxxxx> wrote: > > On Mon, Sep 01, 2025 at 11:43:23PM +0100, Prabhakar wrote: > > Add a SoC-specific `pcs_ops` pointer in `miic_of_data` to allow > > custom phylink PCS callbacks. For RZ/T2H MIIC, implement > > `rzt2h_miic_validate` to restrict valid interfaces to RGMII, RMII, > > and MII. Assign `rzt2h_miic_phylink_ops` with the new validate > > callback to the RZ/T2H MIIC SoC data structure, keeping existing > > PCS support intact for other SoCs. > > This seems completely pointless. Please review commit 508df2de7b3e > ("net: pcs: rzn1-miic: fill in PCS supported_interfaces") to find > out why. > Thank you for pointing this out. I'll drop this patch while sending a v2. Cheers, Prabhakar