RE: [PATCH v2 10/11] can: rcar_can: Do not print alloc_candev() failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for the patch.

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Sent: 22 August 2025 11:17
> Subject: [PATCH v2 10/11] can: rcar_can: Do not print alloc_candev() failures
> 
> If alloc_candev() failed due to out-of-memory, the core memory allocation code has already printed an
> error message.
> If alloc_candev() failed for a different reason, alloc_netdev_mqs() has already printed an error
> message.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Cheers,
Biju

> ---
> v2:
>   - New.
> ---
>  drivers/net/can/rcar/rcar_can.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c index
> de1829477659757c..51bf8f7e71824ac8 100644
> --- a/drivers/net/can/rcar/rcar_can.c
> +++ b/drivers/net/can/rcar/rcar_can.c
> @@ -773,7 +773,6 @@ static int rcar_can_probe(struct platform_device *pdev)
> 
>  	ndev = alloc_candev(sizeof(struct rcar_can_priv), RCAR_CAN_FIFO_DEPTH);
>  	if (!ndev) {
> -		dev_err(dev, "alloc_candev() failed\n");
>  		err = -ENOMEM;
>  		goto fail;
>  	}
> --
> 2.43.0
> 






[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux