Hi Geert
Thank you for reviewing
> > v1 -> v2
> >
> > - Based on latest linux-next/master
>
> Thanks for the update!
> Same comments as on the original v2 below...
(snip)
> > +static const struct renesas_family fam_rcar_gen5 __initconst __maybe_unused = {
> > + .name = "R-Car Gen5",
> > + .reg = 0xfff00044, /* PRR (Product Register) */
>
> Please no hardcoded register addresses for new (DT-only) platforms
> (especially if they don't seem to be correct?).
> I can drop this line while applying.
(snip)
> i.e. will queue in renesas-devel for v6.18, pending acceptance of the
> DT bindings.
Oops, indeed. Sorry about it.
To makes sure working patch, I will post v3 patch
> > @@ -378,6 +388,9 @@ static const struct of_device_id renesas_socs[] __initconst __maybe_unused = {
> > #ifdef CONFIG_ARCH_R8A779H0
> > { .compatible = "renesas,r8a779h0", .data = &soc_rcar_v4m },
> > #endif
> > +#ifdef CONFIG_ARCH_R8A78000
> > + { .compatible = "renesas,r8a78000", .data = &soc_rcar_x5h },
>
> WARNING: DT compatible string "renesas,r8a78000" appears un-documented
> -- check ./Documentation/devicetree/bindings/
The ordering is back and forth, but it will be updated with SoC/Board patch-set.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
