Hi Claudiu, Christophe,
Thanks for the patch.
> -----Original Message-----
> From: Claudiu <claudiu.beznea@xxxxxxxxx>
> Sent: 19 August 2025 06:42
> Subject: [PATCH v5 2/7] phy: renesas: rcar-gen3-usb2: Fix an error handling path in
> rcar_gen3_phy_usb2_probe()
>
> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> If an error occurs after the reset_control_deassert(),
> reset_control_assert() must be called, as already done in the remove function.
>
> Use devm_add_action_or_reset() to add the missing call and simplify the
> .remove() function accordingly.
>
> Fixes: 4eae16375357 ("phy: renesas: rcar-gen3-usb2: Add support to initialize the bus")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> [claudiu.beznea: removed "struct reset_control *rstc = data;" from rcar_gen3_reset_assert()]
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v5:
> - none
>
> Changes in v4:
> - none
>
> Changes in v3:
> - collected tags
>
> Changes in v2:
> - none; this patch is new; re-spinned the Christophe's work at
>
> https://lore.kernel.org/all/TYCPR01MB113329930BA5E2149C9BE2A1986672@xxxxxxxxxxxxxxxxxxxxxxxxxxxx.outloo
> k.com/
>
>
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> index 47beb94cd424..d61c171d454f 100644
> --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> @@ -699,6 +699,11 @@ static enum usb_dr_mode rcar_gen3_get_dr_mode(struct device_node *np)
> return candidate;
> }
>
> +static void rcar_gen3_reset_assert(void *data) {
> + reset_control_assert(data);
> +}
> +
> static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel) {
> struct device *dev = channel->dev;
> @@ -717,6 +722,11 @@ static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel)
> if (ret)
> goto rpm_put;
>
> + ret = devm_add_action_or_reset(dev, rcar_gen3_reset_assert,
> + channel->rstc);
Now 'rstc' can be removed from struct rcar_gen3_chan and use the local rstc pointer
as context variable here.
Cheers,
Biju
> + if (ret)
> + goto rpm_put;
> +
> val = readl(channel->base + USB2_AHB_BUS_CTR);
> val &= ~USB2_AHB_BUS_CTR_MBL_MASK;
> val |= USB2_AHB_BUS_CTR_MBL_INCR4;
> @@ -860,7 +870,6 @@ static void rcar_gen3_phy_usb2_remove(struct platform_device *pdev)
> if (channel->is_otg_channel)
> device_remove_file(&pdev->dev, &dev_attr_role);
>
> - reset_control_assert(channel->rstc);
> pm_runtime_disable(&pdev->dev);
> };
>
> --
> 2.43.0
