Hi,
On 28/07/2025 23:14, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Add the compatible string "renesas,r9a09g057-mipi-dsi" for the Renesas
> RZ/V2H(P) (R9A09G057) SoC. While the MIPI DSI LINK registers are shared
> with the RZ/G2L SoC, the D-PHY register layout differs. Additionally, the
> RZ/V2H(P) uses only two resets compared to three on RZ/G2L, and requires
> five clocks instead of six.
>
> To reflect these hardware differences, update the binding schema to
> support the reduced clock and reset requirements for RZ/V2H(P).
>
> Since the RZ/V2N (R9A09G056) SoC integrates an identical DSI IP to
> RZ/V2H(P), the same "renesas,r9a09g057-mipi-dsi" compatible string is
> reused for RZ/V2N.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v6->v7:
> - Renamed pllclk to pllrefclk
> - Preserved the reviewed by tag from Geert and Krzysztof
>
> v5->v6:
> - Preserved the sort order (by part number).
> - Added reviewed tag from Geert.
>
> v4->v5:
> - No changes
>
> v3->v4:
> - No changes
>
> v2->v3:
> - Collected reviewed tag from Krzysztof
>
> v1->v2:
> - Kept the sort order for schema validation
> - Added `port@1: false` for RZ/V2H(P) SoC
> ---
> .../bindings/display/bridge/renesas,dsi.yaml | 120 +++++++++++++-----
> 1 file changed, 91 insertions(+), 29 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> index 5a99d9b9635e..c20625b8425e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi.yaml
> @@ -14,16 +14,21 @@ description: |
> RZ/G2L alike family of SoC's. The encoder can operate in DSI mode, with
> up to four data lanes.
>
> -allOf:
> - - $ref: /schemas/display/dsi-controller.yaml#
> -
> properties:
> compatible:
> - items:
> + oneOf:
> + - items:
> + - enum:
> + - renesas,r9a07g044-mipi-dsi # RZ/G2{L,LC}
> + - renesas,r9a07g054-mipi-dsi # RZ/V2L
> + - const: renesas,rzg2l-mipi-dsi
> +
> + - items:
> + - const: renesas,r9a09g056-mipi-dsi # RZ/V2N
> + - const: renesas,r9a09g057-mipi-dsi
> +
> - enum:
> - - renesas,r9a07g044-mipi-dsi # RZ/G2{L,LC}
> - - renesas,r9a07g054-mipi-dsi # RZ/V2L
> - - const: renesas,rzg2l-mipi-dsi
> + - renesas,r9a09g057-mipi-dsi # RZ/V2H(P)
>
> reg:
> maxItems: 1
> @@ -49,34 +54,56 @@ properties:
> - const: debug
>
> clocks:
> - items:
> - - description: DSI D-PHY PLL multiplied clock
> - - description: DSI D-PHY system clock
> - - description: DSI AXI bus clock
> - - description: DSI Register access clock
> - - description: DSI Video clock
> - - description: DSI D-PHY Escape mode transmit clock
> + oneOf:
> + - items:
> + - description: DSI D-PHY PLL multiplied clock
> + - description: DSI D-PHY system clock
> + - description: DSI AXI bus clock
> + - description: DSI Register access clock
> + - description: DSI Video clock
> + - description: DSI D-PHY Escape mode transmit clock
> + - items:
> + - description: DSI D-PHY PLL reference clock
> + - description: DSI AXI bus clock
> + - description: DSI Register access clock
> + - description: DSI Video clock
> + - description: DSI D-PHY Escape mode transmit clock
Is this style ok in the bindings? I thought it's necessary to "if" these
kind of blocks based on the compatible.
> clock-names:
> - items:
> - - const: pllclk
> - - const: sysclk
> - - const: aclk
> - - const: pclk
> - - const: vclk
> - - const: lpclk
> + oneOf:
> + - items:
> + - const: pllclk
> + - const: sysclk
> + - const: aclk
> + - const: pclk
> + - const: vclk
> + - const: lpclk
> + - items:
> + - const: pllrefclk
> + - const: aclk
> + - const: pclk
> + - const: vclk
> + - const: lpclk
>
> resets:
> - items:
> - - description: MIPI_DSI_CMN_RSTB
> - - description: MIPI_DSI_ARESET_N
> - - description: MIPI_DSI_PRESET_N
> + oneOf:
> + - items:
> + - description: MIPI_DSI_CMN_RSTB
> + - description: MIPI_DSI_ARESET_N
> + - description: MIPI_DSI_PRESET_N
> + - items:
> + - description: MIPI_DSI_ARESET_N
> + - description: MIPI_DSI_PRESET_N
>
> reset-names:
> - items:
> - - const: rst
> - - const: arst
> - - const: prst
> + oneOf:
> + - items:
> + - const: rst
> + - const: arst
> + - const: prst
> + - items:
> + - const: arst
> + - const: prst
>
> power-domains:
> maxItems: 1
> @@ -130,6 +157,41 @@ required:
>
> unevaluatedProperties: false
>
> +allOf:
> + - $ref: ../dsi-controller.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a09g057-mipi-dsi
> + then:
> + properties:
> + clocks:
> + maxItems: 5
> +
> + clock-names:
> + maxItems: 5
> +
> + resets:
> + maxItems: 2
> +
> + reset-names:
> + maxItems: 2
> + else:
> + properties:
> + clocks:
> + minItems: 6
> +
> + clock-names:
> + minItems: 6
> +
> + resets:
> + minItems: 3
> +
> + reset-names:
> + minItems: 3
> +
Oh... So this one does the selection based on the compatible. And if we
get a new SoC which doesn't fit into the above classification model,
we'll have to restructure the binding (or add a new one)?
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
Tomi
> examples:
> - |
> #include <dt-bindings/clock/r9a07g044-cpg.h>
