> -----Original Message-----
> From: Sergey Shtylyov <sergei.shtylyov@xxxxxxxxx>
> Sent: Thursday, August 28, 2025 3:38 PM
> To: Michael Dege <michael.dege@xxxxxxxxxxx>; Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>;
> niklas.soderlund <niklas.soderlund@xxxxxxxxxxxx>; Paul Barker <paul@xxxxxxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Nikita
> Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH net-next v4 4/4] net: renesas: rswitch: add modifiable ageing time
>
> On 8/28/25 1:23 PM, Michael Dege wrote:
>
> > This commit allows the setting of the MAC table aging in the R-Car S4
>
> Please just use the imperative mood: Allow the setting...
Thank you for pointing it out. I fixed it for the next version. Also, for
[3/4].
>
> > Rswitch using the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute.
> >
> > Signed-off-by: Michael Dege <michael.dege@xxxxxxxxxxx>
> > ---
> > drivers/net/ethernet/renesas/rswitch_l2.c | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/renesas/rswitch_l2.c
> > b/drivers/net/ethernet/renesas/rswitch_l2.c
> > index
> > 49a24464dbb0cf3f3219a0699fc4671ddd71ef03..c57396af70a4b291746d6451eae7
> > cf60b3f89721 100644
> > --- a/drivers/net/ethernet/renesas/rswitch_l2.c
> > +++ b/drivers/net/ethernet/renesas/rswitch_l2.c
> > @@ -193,6 +193,25 @@ static int rswitch_netdevice_event(struct notifier_block *nb,
> > return NOTIFY_OK;
> > }
> >
> > +static int rswitch_update_ageing_time(struct net_device *ndev,
> > +clock_t time) {
> > + struct rswitch_device *rdev = netdev_priv(ndev);
> > + u32 reg_val;
> > +
> > + if (!is_rdev(ndev))
> > + return -ENODEV;
> > +
> > + if (!FIELD_FIT(FWMACAGC_MACAGT, time))
> > + return -EINVAL;
> > +
> > + rdev = netdev_priv(ndev);
>
> Haven't you already initialized rdev to the same value above?
Good point, also fixed for v5.
Best regards,
Michael
>
> [...]
>
> MBR, Sergey
________________________________
Renesas Electronics Europe GmbH
Registered Office: Arcadiastrasse 10
DE-40472 Duesseldorf
Commercial Registry: Duesseldorf, HRB 3708
Managing Director: Carsten Jauch
VAT-No.: DE 14978647
Tax-ID-No: 105/5839/1793
Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.
