Hi Geert,
Thanks for your review!
On Tue, Sep 02, 2025 at 02:19:16PM +0200, Geert Uytterhoeven wrote:
> Hi Tommaso,
>
> On Wed, 20 Aug 2025 at 12:05, Tommaso Merciai
> <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> > Prevent issues during reset deassertion by re-asserting the reset if a
> > timeout occurs when trying to deassert. This ensures the reset line is in a
> > known state and improves reliability for hardware that may not immediately
> > clear the reset monitor bit.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/rzv2h-cpg.c
> > +++ b/drivers/clk/renesas/rzv2h-cpg.c
> > @@ -865,9 +866,16 @@ static int __rzv2h_cpg_assert(struct reset_controller_dev *rcdev,
> > reg = GET_RST_MON_OFFSET(priv->resets[id].mon_index);
> > mask = BIT(monbit);
> >
> > - return readl_poll_timeout_atomic(priv->base + reg, value,
> > - assert ? (value & mask) : !(value & mask),
> > - 10, 200);
> > + ret = readl_poll_timeout_atomic(priv->base + reg, value,
> > + assert ? (value & mask) : !(value & mask),
> > + 10, 200);
> > + if (ret && !assert) {
> > + dev_warn(rcdev->dev, "deassert timeout, re-asserting reset id %ld\n", id);
> > + value = mask << 16;
> > + writel(value, priv->base + GET_RST_OFFSET(priv->resets[id].reset_index));
> > + }
>
> Same questions as for the previous patch:
> Is this an issue you've seen during actual use?
> Would it make sense to print warnings on assertion timeouts, too?
Same here.
Thank & Regards,
Tommaso
>
> > +
> > + return ret;
> > }
> >
> > static int rzv2h_cpg_assert(struct reset_controller_dev *rcdev,
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
