Hi Geert, Thank you for the review. On Tue, Sep 2, 2025 at 2:02 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On Mon, 1 Sept 2025 at 20:30, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add clock definitions for Ethernet (ETCLK A-E) and GMAC (GMAC0-2) > > peripherals to both R9A09G077 and R9A09G087 SoCs. These definitions > > are required for describing Ethernet and GMAC devices in device trees. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h > > +++ b/include/dt-bindings/clock/renesas,r9a09g077-cpg-mssr.h > > @@ -26,5 +26,14 @@ > > #define R9A09G077_CLK_PCLKL 14 > > #define R9A09G077_SDHI_CLKHS 15 > > #define R9A09G077_USB_CLK 16 > > +#define R9A09G077_ETCLKA 17 > > +#define R9A09G077_ETCLKB 18 > > +#define R9A09G077_ETCLKC 19 > > +#define R9A09G077_ETCLKD 20 > > +#define R9A09G077_ETCLKE 21 > > These five LGTM. > > > +#define R9A09G077_GMAC0_PCLKH 22 > > +#define R9A09G077_GMAC1_PCLKAH 23 > > +#define R9A09G077_GMAC2_PCLKAH 24 > > I doubt you really need these, cfr. my comments on [PATCH v2 2/2]. > As agreed on patch 2/2, I will drop these macros in v3. Cheers, Prabhakar
