Hi Geert, Thank you for the review. On Wed, Sep 3, 2025 at 10:12 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Tue, 2 Sept 2025 at 14:17, Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > On Tue, Sep 2, 2025 at 9:45 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > > On Mon, Sep 01, 2025 at 11:43:14PM +0100, Prabhakar wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > Extend the RZN1 MIIC device-tree binding schema to cover the RZ/T2H > > > > and RZ/N2H SoCs. These SoCs have a MIIC converter similar to RZ/N1, but > > > > with some differences: > > > > > > > > - RZ/T2H has two reset lines; RZ/N1 has none. > > > > - RZ/N1 supports 5 MIIC ports, whereas RZ/T2H supports 4 ports. > > > > - On RZ/N1, MIIC ports can be mapped to various endpoints such as RTOS > > > > MAC ports, switch ports, EtherCAT ports, SERCOS ports, HSR ports, or > > > > fixed PHY ports (covering PHY input indices 0-13). On RZ/T2H, ports > > > > can connect to EtherCAT slave ports, Ethernet switch ports, or GMAC > > > > ports (mapped to PHY input indices 0-8). > > > > - There are register bit differences between the SoCs, and RZ/N1 has > > > > additional registers currently unused by the driver. > > > > - On RZ/T2H, the switch is connected to GMAC0 whereas on RZ/N1 the > > > > switch can be connected to GMAC2/HW-RTOS GMAC. > > > > > > > > To accommodate these differences, a new generic compatible string > > > > `renesas,rzt2h-miic` is introduced for both RZ/T2H and RZ/N2H variants. > > Until now, we didn't have any family-specific "renesas,rzt2h-*" > compatible values. Instead, we always used " renesas,r9a09g077-<foo>" > as a fallback for "renesas,r9a09g087-<foo>". > Is there any good reason to start deviating from this? > Right good point, I'll continue using the previous approach and use T2H compatible as a fallback for N2H. > > > > > > > > The DT schema is updated to validate these differences and ensure proper > > > > port and reset configurations per SoC. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > --- a/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml > > > > +++ b/Documentation/devicetree/bindings/net/pcs/renesas,rzn1-miic.yaml > > > > @@ -4,13 +4,14 @@ > > > > $id: http://devicetree.org/schemas/net/pcs/renesas,rzn1-miic.yaml# > > > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > > > -title: Renesas RZ/N1 MII converter > > > > +title: Renesas RZ/{N1, N2H, T2H} MII converter > > > > > > Don't use regex here. RZ/N1, RZ/N2H and TZ/T2H.... > > > > > Ok, I will use it as above (s/TZ/T2H/RZ/T2H). > > s@TZ/T2H@RZ/T2H@ ;-) > :-) Cheers, Prabhakar
