Hi Geert,
Thank you for the review.
On Wed, Sep 3, 2025 at 3:05 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Thu, 21 Aug 2025 at 18:19, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Add EHCI, OHCI, PHY and HSUSB nodes to RZ/T2H (R9A09G077) SoC DTSI.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
>
> > + hsusb: usb@92041000 {
> > + compatible = "renesas,usbhs-r9a09g077";
> > + reg = <0 0x92041000 0 0x10000>;
>
> "0x1000", as the region starting at 0x92043000 is marked reserved?
> I can fix that while applying.
>
Ouch agreed, thank you for taking care of this (also for RZ/N2H patch).
Cheers,
Prabhakar
> > + interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 589 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 408>;
> > + phys = <&usb2_phy 3>;
> > + phy-names = "usb";
> > + power-domains = <&cpg>;
> > + status = "disabled";
> > + };
> > +
> > sdhi0: mmc@92080000 {
> > compatible = "renesas,sdhi-r9a09g077",
> > "renesas,sdhi-r9a09g057";
>
> The rest LGTM.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
