On Thu, Sep 04, 2025 at 09:39:48PM +0100, Prabhakar wrote: > plat_dat->init = renesas_gbeth_init; > plat_dat->exit = renesas_gbeth_exit; > - plat_dat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY | > - STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP | > - STMMAC_FLAG_SPH_DISABLE; > + plat_dat->flags |= gbeth->of_data->stmmac_flags; You include the first two flags in your new device. I would like to see at least STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP always being set. The only reason we have the STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP flag is to avoid changing existing behaviour and causing regressions. New stuff should always set this. If there is a reason not to have this set (e.g., PCS doesn't support it) then we need to make that a PCS property and extend phylink's EEE support. If there's something wrong in the setup that stmmac does for EEE, then I'd like to hear about it as well. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
