Hi Marek,
On 2025-08-28 17:31:08 +0200, Marek Vasut wrote:
> On 8/28/25 12:14 AM, Niklas Söderlund wrote:
>
> Nitpicks only, see below.
Thanks for your nitpicks, will fix for next version.
>
> [...]
>
> > +&{/} {
> > + clk_cam_j1: clk_cam_j1 {
>
> -clk_cam_j1: clk_cam_j1
> +clk_cam_j1: clk-cam-j1
> ^ ^
>
> The nodes in Sparrow Hawk root node use - instead of _ in their node names.
>
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <24000000>;
> > + };
> > +
> > + /* Page 29 / CSI_IF_CN / J1 */
> > + reg_cam_j1: reg_cam_j1 {
>
> Here as well.
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "reg_cam_j1";
>
> Is the "reg_" prefix needed ? Maybe "cam-J1" would be better ?
>
> > + enable-active-high;
> > + gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> > + };
> > +};
> [...]
--
Kind Regards,
Niklas Söderlund
