Hi Wolfram, Thanks for your work. On 2025-09-09 10:46:20 +0200, Wolfram Sang wrote: > The current default values for R-Car Gen4 are from a V4H Rev3.0 SoC. > They seem incomplete because of the same values for all THS instances. > Also, the bits to flag valid fuses were not set. So, better use the > values from the Rev2.2 SoC which have the valid flags set. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- > drivers/thermal/renesas/rcar_gen3_thermal.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c > index 07b53d4f2683..b7026ab733d4 100644 > --- a/drivers/thermal/renesas/rcar_gen3_thermal.c > +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c > @@ -372,12 +372,12 @@ static const struct rcar_gen3_thermal_fuse_default rcar_gen3_thermal_fuse_defaul > }; > > static const struct rcar_gen3_thermal_fuse_default rcar_gen3_thermal_fuse_default_info_gen4 = { > - .ptat = { 3274, 2164, 985 }, > - .thcodes = { /* All four THS units share the same trimming */ > - { 3218, 2617, 1980 }, > - { 3218, 2617, 1980 }, > - { 3218, 2617, 1980 }, > - { 3218, 2617, 1980 }, > + .ptat = { 3146, 2076, 928 }, > + .thcodes = { > + { 3092, 2505, 1881 }, > + { 2181, 2609, 2001 }, If these values come from the board I think they do, s/2181/3181/ ? > + { 3175, 2587, 1962 }, > + { 3163, 2592, 1986 }, > } > }; > > -- > 2.47.2 > -- Kind Regards, Niklas Söderlund