Jacopo, >-----Original Message----- >From: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> >Sent: Saturday, August 2, 2025 5:23 PM >To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Devarsh Thakkar ><devarsht@xxxxxx>; Benoit Parrot <bparrot@xxxxxx>; Hans Verkuil ><hverkuil@xxxxxxxxxx>; Mike Isely <isely@xxxxxxxxx>; Laurent Pinchart ><laurent.pinchart@xxxxxxxxxxxxxxxx>; Hans de Goede <hansg@xxxxxxxxxx>; >Parthiban Veerasooran <parthiban.veerasooran@xxxxxxxxxxxxx>; Christian >Gromm <christian.gromm@xxxxxxxxxxxxx>; Greg Kroah-Hartman ><gregkh@xxxxxxxxxxxxxxxxxxx>; Alex Shi <alexs@xxxxxxxxxx>; Yanteng Si ><si.yanteng@xxxxxxxxx>; Dongliang Mu <dzm91@xxxxxxxxxxx>; Jonathan >Corbet <corbet@xxxxxxx>; Tomasz Figa <tfiga@xxxxxxxxxxxx>; Marek >Szyprowski <m.szyprowski@xxxxxxxxxxx>; Andy Walls ><awalls@xxxxxxxxxxxxxxxx>; Michael Tretter <m.tretter@xxxxxxxxxxxxxx>; >Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Bin Liu ><bin.liu@xxxxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>; >AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>; >Dmitry Osipenko <digetx@xxxxxxxxx>; Thierry Reding ><thierry.reding@xxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>; >Mirela Rabulea <mirela.rabulea@xxxxxxx>; Shawn Guo ><shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Fabio >Estevam <festevam@xxxxxxxxx>; Kieran Bingham ><kieran.bingham+renesas@xxxxxxxxxxxxxxxx>; Michal Simek ><michal.simek@xxxxxxx>; Ming Qian <ming.qian@xxxxxxx>; Zhou Peng ><eagle.zhou@xxxxxxx>; Xavier Roumegue <xavier.roumegue@xxxxxxxxxxx>; >Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Vikash Garodia ><quic_vgarodia@xxxxxxxxxxx>; Dikshita Agarwal ><quic_dikshita@xxxxxxxxxxx>; Abhinav Kumar <abhinav.kumar@xxxxxxxxx>; >Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>; Sylwester Nawrocki ><sylvester.nawrocki@xxxxxxxxx>; Jernej Skrabec ><jernej.skrabec@xxxxxxxxx>; Chen-Yu Tsai <wens@xxxxxxxx>; Samuel >Holland <samuel@xxxxxxxxxxxx>; Daniel Almeida ><daniel.almeida@xxxxxxxxxxxxx>; Neil Armstrong ><neil.armstrong@xxxxxxxxxx>; Kevin Hilman <khilman@xxxxxxxxxxxx>; >Jerome Brunet <jbrunet@xxxxxxxxxxxx>; Martin Blumenstingl ><martin.blumenstingl@xxxxxxxxxxxxxx>; Nas Chung ><nas.chung@xxxxxxxxxxxxxxx>; Jackson Lee <jackson.lee@xxxxxxxxxxxxxxx>; >Minghsiu Tsai <minghsiu.tsai@xxxxxxxxxxxx>; Houlong Wei ><houlong.wei@xxxxxxxxxxxx>; Andrew-CT Chen <andrew- >ct.chen@xxxxxxxxxxxx>; Tiffany Lin <tiffany.lin@xxxxxxxxxxxx>; Yunfei >Dong <yunfei.dong@xxxxxxxxxxxx>; Geert Uytterhoeven ><geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; Mikhail >Ulyanov <mikhail.ulyanov@xxxxxxxxxxxxxxxxxx>; Jacob Chen <jacob- >chen@xxxxxxxxxx>; Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>; >Heiko Stuebner <heiko@xxxxxxxxx>; Detlev Casanova ><detlev.casanova@xxxxxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>; >Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Sylwester Nawrocki ><s.nawrocki@xxxxxxxxxxx>; Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>; >Andrzej Pietrasiewicz <andrzejtp2010@xxxxxxxxx>; Jacek Anaszewski ><jacek.anaszewski@xxxxxxxxx>; Hajda, Andrzej <andrzej.hajda@xxxxxxxxx>; >Fabien Dessenne <fabien.dessenne@xxxxxxxxxxx>; Hugues Fruchet ><hugues.fruchet@xxxxxxxxxxx>; Jean-Christophe Trotin <jean- >christophe.trotin@xxxxxxxxxxx>; Maxime Coquelin ><mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue ><alexandre.torgue@xxxxxxxxxxx>; Nicolas Dufresne ><nicolas.dufresne@xxxxxxxxxxxxx>; Benjamin Gaignard ><benjamin.gaignard@xxxxxxxxxxxxx>; Steve Longerbeam ><slongerbeam@xxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; Paul >Kocialkowski <paulk@xxxxxxxxxxx>; Niklas Söderlund ><niklas.soderlund@xxxxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Todor >Tomov <todor.too@xxxxxxxxx>; Vladimir Zapolskiy ><vladimir.zapolskiy@xxxxxxxxxx>; Corentin Labbe <clabbe@xxxxxxxxxxxx>; >Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Cao, Bingbu ><bingbu.cao@xxxxxxxxx>; Qiu, Tian Shu <tian.shu.qiu@xxxxxxxxx>; >Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx> >Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux- >staging@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux- >tegra@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-renesas- >soc@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux-samsung- >soc@xxxxxxxxxxxxxxx; linux-sunxi@xxxxxxxxxxxxxxx; linux- >usb@xxxxxxxxxxxxxxx; linux-amlogic@xxxxxxxxxxxxxxxxxxx; linux- >rockchip@xxxxxxxxxxxxxxxxxxx; linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; >mjpeg-users@xxxxxxxxxxxxxxxxxxxxx; Jacopo Mondi ><jacopo.mondi@xxxxxxxxxxxxxxxx> >Subject: [PATCH 63/65] media: ipu6: isys: Don't set >V4L2_FL_USES_V4L2_FH manually > >From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > >The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant >to be set manually by drivers. Drop it from the ipu6-isys driver. > >Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> >--- > drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >index >24a2ef93474cc400f64eb1d50bc760ee66124d1b..f3f3bc0615e5dc698be5c479dfed8 >ef2eb49cbfb 100644 >--- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >+++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >@@ -1306,7 +1306,6 @@ int ipu6_isys_video_init(struct ipu6_isys_video >*av) > __ipu6_isys_vidioc_try_fmt_meta_cap(av, &format_meta); > av->meta_fmt = format_meta.fmt.meta; > >- set_bit(V4L2_FL_USES_V4L2_FH, &av->vdev.flags); > video_set_drvdata(&av->vdev, av); > > ret = video_register_device(&av->vdev, VFL_TYPE_VIDEO, -1); > >-- >2.49.0 Thanks for the patch. Reviewed-by: Bingbu Cao <bingbu.cao@xxxxxxxxx>
