>-----Original Message-----
>From: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
>Sent: Saturday, August 2, 2025 5:23 PM
>To: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Devarsh Thakkar
><devarsht@xxxxxx>; Benoit Parrot <bparrot@xxxxxx>; Hans Verkuil
><hverkuil@xxxxxxxxxx>; Mike Isely <isely@xxxxxxxxx>; Laurent Pinchart
><laurent.pinchart@xxxxxxxxxxxxxxxx>; Hans de Goede <hansg@xxxxxxxxxx>;
>Parthiban Veerasooran <parthiban.veerasooran@xxxxxxxxxxxxx>; Christian
>Gromm <christian.gromm@xxxxxxxxxxxxx>; Greg Kroah-Hartman
><gregkh@xxxxxxxxxxxxxxxxxxx>; Alex Shi <alexs@xxxxxxxxxx>; Yanteng Si
><si.yanteng@xxxxxxxxx>; Dongliang Mu <dzm91@xxxxxxxxxxx>; Jonathan
>Corbet <corbet@xxxxxxx>; Tomasz Figa <tfiga@xxxxxxxxxxxx>; Marek
>Szyprowski <m.szyprowski@xxxxxxxxxxx>; Andy Walls
><awalls@xxxxxxxxxxxxxxxx>; Michael Tretter <m.tretter@xxxxxxxxxxxxxx>;
>Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>; Bin Liu
><bin.liu@xxxxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>;
>AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>;
>Dmitry Osipenko <digetx@xxxxxxxxx>; Thierry Reding
><thierry.reding@xxxxxxxxx>; Jonathan Hunter <jonathanh@xxxxxxxxxx>;
>Mirela Rabulea <mirela.rabulea@xxxxxxx>; Shawn Guo
><shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Fabio
>Estevam <festevam@xxxxxxxxx>; Kieran Bingham
><kieran.bingham+renesas@xxxxxxxxxxxxxxxx>; Michal Simek
><michal.simek@xxxxxxx>; Ming Qian <ming.qian@xxxxxxx>; Eagle Zhou
><eagle.zhou@xxxxxxx>; Xavier Roumegue (OSS)
><xavier.roumegue@xxxxxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>;
>Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>; Dikshita Agarwal
><quic_dikshita@xxxxxxxxxxx>; Abhinav Kumar <abhinav.kumar@xxxxxxxxx>;
>Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>; Sylwester Nawrocki
><sylvester.nawrocki@xxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx>;
>Chen-Yu Tsai <wens@xxxxxxxx>; Samuel Holland <samuel@xxxxxxxxxxxx>;
>Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>; Neil Armstrong
><neil.armstrong@xxxxxxxxxx>; Kevin Hilman <khilman@xxxxxxxxxxxx>; Jerome
>Brunet <jbrunet@xxxxxxxxxxxx>; Martin Blumenstingl
><martin.blumenstingl@xxxxxxxxxxxxxx>; Nas Chung
><nas.chung@xxxxxxxxxxxxxxx>; Jackson Lee
><jackson.lee@xxxxxxxxxxxxxxx>; Minghsiu Tsai
><minghsiu.tsai@xxxxxxxxxxxx>; Houlong Wei <houlong.wei@xxxxxxxxxxxx>;
>Andrew-CT Chen <andrew-ct.chen@xxxxxxxxxxxx>; Tiffany Lin
><tiffany.lin@xxxxxxxxxxxx>; Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>;
>Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Magnus Damm
><magnus.damm@xxxxxxxxx>; Mikhail Ulyanov
><mikhail.ulyanov@xxxxxxxxxxxxxxxxxx>; Jacob Chen <jacob-
>chen@xxxxxxxxxx>; Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>; Heiko
>Stuebner <heiko@xxxxxxxxx>; Detlev Casanova
><detlev.casanova@xxxxxxxxxxxxx>; Krzysztof Kozlowski <krzk@xxxxxxxxxx>;
>Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Sylwester Nawrocki
><s.nawrocki@xxxxxxxxxxx>; Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>;
>Andrzej Pietrasiewicz <andrzejtp2010@xxxxxxxxx>; Jacek Anaszewski
><jacek.anaszewski@xxxxxxxxx>; Andrzej Hajda <andrzej.hajda@xxxxxxxxx>;
>Fabien Dessenne <fabien.dessenne@xxxxxxxxxxx>; Hugues Fruchet
><hugues.fruchet@xxxxxxxxxxx>; Jean-Christophe Trotin <jean-
>christophe.trotin@xxxxxxxxxxx>; Maxime Coquelin
><mcoquelin.stm32@xxxxxxxxx>; Alexandre Torgue
><alexandre.torgue@xxxxxxxxxxx>; Nicolas Dufresne
><nicolas.dufresne@xxxxxxxxxxxxx>; Benjamin Gaignard
><benjamin.gaignard@xxxxxxxxxxxxx>; Steve Longerbeam
><slongerbeam@xxxxxxxxx>; Maxime Ripard <mripard@xxxxxxxxxx>; Paul
>Kocialkowski <paulk@xxxxxxxxxxx>; Niklas Söderlund
><niklas.soderlund@xxxxxxxxxxxx>; Robert Foss <rfoss@xxxxxxxxxx>; Todor
>Tomov <todor.too@xxxxxxxxx>; Vladimir Zapolskiy
><vladimir.zapolskiy@xxxxxxxxxx>; Corentin Labbe <clabbe@xxxxxxxxxxxx>;
>Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Bingbu Cao
><bingbu.cao@xxxxxxxxx>; Tianshu Qiu <tian.shu.qiu@xxxxxxxxx>; Stanislaw
>Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
>Cc: linux-media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
>staging@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-
>tegra@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx;
>linux-arm-msm@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
>sunxi@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; linux-
>amlogic@xxxxxxxxxxxxxxxxxxx; linux-rockchip@xxxxxxxxxxxxxxxxxxx; linux-
>stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx; mjpeg-users@xxxxxxxxxxxxxxxxxxxxx;
>Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
>Subject: [EXT] [PATCH 13/65] media: amphion: Make some vpu_v4l2 functions
>static
>
>Caution: This is an external email. Please take care when clicking links or
>opening attachments. When in doubt, report the message using the 'Report
>this email' button
>
>
>From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
>Some functions defined in vpu_v4l2.c are never used outside of that
>compilation unit. Make them static.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
Reviewed-by: Ming Qian <ming.qian@xxxxxxxxxxx>
>---
> drivers/media/platform/amphion/vpu_v4l2.c | 12 +++++++++---
>drivers/media/platform/amphion/vpu_v4l2.h | 8 --------
> 2 files changed, 9 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.c
>b/drivers/media/platform/amphion/vpu_v4l2.c
>index
>74668fa362e24fd34829b500e99c8455a9413fc1..306d94e0f8e79faaacfa35b28e
>5786860f7bd1ca 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.c
>+++ b/drivers/media/platform/amphion/vpu_v4l2.c
>@@ -24,6 +24,11 @@
> #include "vpu_msgs.h"
> #include "vpu_helpers.h"
>
>+static char *vpu_type_name(u32 type)
>+{
>+ return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture"; }
>+
> void vpu_inst_lock(struct vpu_inst *inst) {
> mutex_lock(&inst->lock);
>@@ -42,7 +47,7 @@ dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer
>*vb, u32 plane_no)
> vb->planes[plane_no].data_offset; }
>
>-unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no)
>+static unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32
>+plane_no)
> {
> if (plane_no >= vb->num_planes)
> return 0;
>@@ -81,7 +86,7 @@ void vpu_v4l2_set_error(struct vpu_inst *inst)
> vpu_inst_unlock(inst);
> }
>
>-int vpu_notify_eos(struct vpu_inst *inst)
>+static int vpu_notify_eos(struct vpu_inst *inst)
> {
> static const struct v4l2_event ev = {
> .id = 0,
>@@ -573,7 +578,8 @@ static void vpu_vb2_buf_finish(struct vb2_buffer *vb)
> call_void_vop(inst, on_queue_empty, q->type); }
>
>-void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state)
>+static void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type,
>+ enum vb2_buffer_state state)
> {
> struct vb2_v4l2_buffer *buf;
>
>diff --git a/drivers/media/platform/amphion/vpu_v4l2.h
>b/drivers/media/platform/amphion/vpu_v4l2.h
>index
>56f2939fa84d07b7ea07e889ab5ad3bb7ca9ab5c..4a87b06ae520306ede356b6f
>3309d8b4a67c204a 100644
>--- a/drivers/media/platform/amphion/vpu_v4l2.h
>+++ b/drivers/media/platform/amphion/vpu_v4l2.h
>@@ -26,15 +26,12 @@ void vpu_skip_frame(struct vpu_inst *inst, int count);
>struct vb2_v4l2_buffer *vpu_find_buf_by_sequence(struct vpu_inst *inst, u32
>type, u32 sequence); struct vb2_v4l2_buffer *vpu_find_buf_by_idx(struct
>vpu_inst *inst, u32 type, u32 idx); void vpu_v4l2_set_error(struct vpu_inst
>*inst); -int vpu_notify_eos(struct vpu_inst *inst); int
>vpu_notify_source_change(struct vpu_inst *inst); int
>vpu_set_last_buffer_dequeued(struct vpu_inst *inst, bool eos); -void
>vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum
>vb2_buffer_state state); int vpu_get_num_buffers(struct vpu_inst *inst, u32
>type); bool vpu_is_source_empty(struct vpu_inst *inst);
>
> dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer *vb, u32 plane_no); -
>unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no); static
>inline struct vpu_format *vpu_get_format(struct vpu_inst *inst, u32 type) {
> if (V4L2_TYPE_IS_OUTPUT(type))
>@@ -43,11 +40,6 @@ static inline struct vpu_format *vpu_get_format(struct
>vpu_inst *inst, u32 type)
> return &inst->cap_format; }
>
>-static inline char *vpu_type_name(u32 type) -{
>- return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture";
>-}
>-
> static inline int vpu_vb_is_codecconfig(struct vb2_v4l2_buffer *vbuf) { #ifdef
>V4L2_BUF_FLAG_CODECCONFIG
>
>--
>2.49.0
