RE: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 04 August 2025 09:03
> Subject: Re: [PATCH v2] arm64: dts: renesas: rzg2lc-smarc: Disable CAN-FD channel0
> 
> Hi Biju,
> 
> Thanks for your patch!
> 
> On Fri, 1 Aug 2025 at 14:20, Biju <biju.das.au@xxxxxxxxx> wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > On RZ/G2LC SMARC EVK, CAN-FD channel0 is not populated and channel0 is
> > a required property. Currently we are deleting a wrong node. Fixing
> > the
> 
> s/wrong/nonexistent/

Agreed.

> 
> > wrong node invoked dtb warning message. Disable CAN-FD channel0
> > instead of deleting the node.
> >
> > Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
> > channel 1")
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > v1->v2:
> >  * Updated the commit header and description.
> >  * Fixed the bot warning by disabling the channel instead of deleting it.
> > ---
> >  arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > index 345b779e4f60..0d357516e0be 100644
> > --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > @@ -48,7 +48,9 @@ sound_card {
> >  #if (SW_SCIF_CAN || SW_RSPI_CAN)
> >  &canfd {
> >         pinctrl-0 = <&can1_pins>;
> > -       /delete-node/ channel@0;
> 
> Please insert a blank line between properties and nodes.

Ok.

> 
> > +       channel0 {
> > +               status = "disabled";
> > +       };
> >  };
> >  #else
> >  &canfd {
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v6.18
> with the above fixed.


Thanks for taking care this.

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux