On Tue, Jul 29, 2025 at 04:59:14PM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Add support for the RZ/T2H watchdog timer. The RZ/T2H requires control of > the watchdog counter using the WDT Debug Control Register (WDTDCR), which > allows explicitly stopping and starting the counter. This behavior differs > from RZ/V2H, which doesn't use WDTDCR, so the driver is extended to handle > this requirement. > > To support this, a new `wdtdcr` flag is introduced in the `rzv2h_of_data` > structure. When set, the driver maps the WDTDCR register and uses it to > control the watchdog counter in the start, stop, and restart callbacks. > Additionally, the clock divisor and count source for RZ/T2H are defined > to match its hardware configuration. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Well, this new DCR register is really strange, especially its location in a seperate resource. But given that, your code handling it looks okay to me, so: Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>