RE: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: 01 August 2025 10:16
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
> 
> On 01/08/2025 10:11, Biju Das wrote:
> > Hi Geert,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >> Sent: 01 August 2025 08:30
> >> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for
> >> deleting node
> >>
> >> Hi Biju,
> >>
> >> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@xxxxxxxxx> wrote:
> >>> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >>>
> >>> Fix typo for deleting node 'channel@0'->'channel0'.
> >>>
> >>> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable
> >>> CANFD channel 1")
> >>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >>
> >> Thanks for your patch!
> >>
> >>> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> >>> @@ -48,7 +48,7 @@ sound_card {
> >>>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
> >>>  &canfd {
> >>>         pinctrl-0 = <&can1_pins>;
> >>> -       /delete-node/ channel@0;
> >>> +       /delete-node/ channel0;
> >>
> >> As pointed out by Rob's bot, you must not delete this node.
> >> Instead, set channel0's status to disabled.
> >
> > OK. Will fix this in next version.
> 
> Please TEST your patch before sending it. This would avoid this entire discussion.

Sorry for that. Will take care next time.

Cheers,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux