Hi Geert
> > +static const struct renesas_family fam_rcar_gen5 __initconst __maybe_unused = {
> > + .name = "R-Car Gen5",
> > + .reg = 0xfff00044, /* PRR (Product Register) */
>
> Please no hardcoded register addresses for new (DT-only) platforms
> (especially if they don't seem to be correct?).
> I can drop this line while applying.
OK, thanks.
Will adjust on DT side.
> > @@ -378,6 +388,9 @@ static const struct of_device_id renesas_socs[] __initconst __maybe_unused = {
> > #ifdef CONFIG_ARCH_R8A779H0
> > { .compatible = "renesas,r8a779h0", .data = &soc_rcar_v4m },
> > #endif
> > +#ifdef CONFIG_ARCH_R8A78000
> > + { .compatible = "renesas,r8a78000", .data = &soc_rcar_x5h },
>
> scripts/checkpatch.pl:
>
> WARNING: DT compatible string "renesas,r8a78000" appears un-documented
> -- check ./Documentation/devicetree/bindings/
Sorry I didn't explain about it. Yes.
My plan is update SoC and board DT DoC in the same time, so it will be
included in next patch-set (= DoC support + X5H support + Ironhide suppor)
Thank you for your help !!
Best regards
---
Kuninori Morimoto
