Hi Geert, > -----Original Message----- > From: Biju Das > Sent: 30 July 2025 15:12 > Subject: RE: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support for SD_BUF0 in polling mode > > Hi Geert/Wolfram, > > > -----Original Message----- > > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Sent: 30 July 2025 14:57 > > Subject: Re: [PATCH v2 1/2] mmc: tmio: Add 64-bit read/write support > > for SD_BUF0 in polling mode > > > > Hi Wolfram, > > > > On Wed, 30 Jul 2025 at 11:17, Wolfram Sang <wsa-dev@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > In file included from drivers/mmc/host/uniphier-sd.c:21: > > > > >> drivers/mmc/host/tmio_mmc.h:249:2: error: call to undeclared > > > > >> function 'ioread64_rep'; ISO C99 and later do not support > > > > >> implicit function declarations > > > > >> [-Wimplicit-function-declaration] > > > > 249 | ioread64_rep(host->ctl + (addr << host->bus_shift), buf, count); > > > > | ^ > > > > >> drivers/mmc/host/tmio_mmc.h:255:2: error: call to undeclared > > > > >> function 'iowrite64_rep'; ISO C99 and later do not support > > > > >> implicit function declarations > > > > >> [-Wimplicit-function-declaration] > > > > 255 | iowrite64_rep(host->ctl + (addr << host->bus_shift), buf, count); > > > > | ^ > > > > > > Sigh, then the guard seems to be ARM64 after all :( > > > > ioread64_rep() is defined in include/asm-generic/io.h, and powerpc does include that. > > > > Perhaps drivers/mmc/host/tmio_mmc.h should just include <linux/io.h>? > > This does not fix the issue. Reason is CONFIG_GENERIC_IOMAP=y So, ioread64_rep() is excluded. Cheers, Biju
