On Tue, Jul 22, 2025 at 05:34:40PM +0200, Wolfram Sang wrote:
i3c: Add timing parameters for controllers
> Timing values from the specification and a subsystem wide default value
> are added to be consumed by controller drivers.
Add standard timing value defination from specification.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> Change since v2:
> * new patch
>
> include/linux/i3c/master.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
> index 7b8e7f22f013..da6754bc254c 100644
> --- a/include/linux/i3c/master.h
> +++ b/include/linux/i3c/master.h
> @@ -254,8 +254,15 @@ struct i3c_device {
> #define I3C_BUS_I2C_FM_SCL_MAX_RATE 400000
> #define I3C_BUS_I3C_SCL_MAX_RATE 12900000
> #define I3C_BUS_I3C_SCL_TYP_RATE 12500000
> +#define I3C_BUS_TAVAL_MIN_NS 1000
Can you add commments like
/* ref i3c spec v1.1.1, section x.y.z */
Frank
> +#define I3C_BUS_TBUF_MIXED_FM_MIN_NS 1300
> +#define I3C_BUS_THIGH_MIXED_MAX_NS 41
> +#define I3C_BUS_TIDLE_MIN_NS 200000
> #define I3C_BUS_TLOW_OD_MIN_NS 200
>
> +/* TODO: Document a reason for this value */
> +#define I3C_BUS_XFER_TIMEOUT_TYP_JIF (msecs_to_jiffies(1000))
> +
> /**
> * enum i3c_bus_mode - I3C bus mode
> * @I3C_BUS_MODE_PURE: only I3C devices are connected to the bus. No limitation
> --
> 2.47.2
>
