On Wed, Jul 09, 2025 at 09:16:06PM +0200, Geert Uytterhoeven wrote: > Hi all, > > This patch series converts the Renesas media drivers from the old > SIMPLE_DEV_PM_OPS(), SET_SYSTEM_SLEEP_PM_OPS(), and SET_RUNTIME_PM_OPS() > helpers to the modern DEFINE_SIMPLE_DEV_PM_OPS(), SYSTEM_SLEEP_PM_OPS(), > RUNTIME_PM_OPS(), pm_ptr(), and pm_sleep_ptr() helpers. This lets us > drop the __maybe_unused annotations from power management callbacks, and > reduces kernel size in case power management or sleep support is not > enabled. There is lots of cargo-cult in drivers when it comes to PM. Cleaning things up is good, but we also need to document the recommended usage. SIMPLE_DEV_PM_OPS() is marked as deprecated, but SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() are not. Usage of pm_ptr is also not documented. Could you send a documentation patch to address this ? > Thanks for your comments! > > Geert Uytterhoeven (5): > media: renesas: rcar_drif: Convert to DEFINE_SIMPLE_DEV_PM_OPS() > media: renesas: rcar-vin: Convert to DEFINE_SIMPLE_DEV_PM_OPS() > media: renesas: fdp1: Convert to RUNTIME_PM_OPS() > media: renesas: ceu: Convert to RUNTIME_PM_OPS() > media: renesas: vsp1: Convert to SYSTEM_SLEEP/RUNTIME_PM_OPS() > > .../media/platform/renesas/rcar-vin/rcar-core.c | 8 ++++---- > drivers/media/platform/renesas/rcar_drif.c | 10 +++++----- > drivers/media/platform/renesas/rcar_fdp1.c | 10 ++++------ > drivers/media/platform/renesas/renesas-ceu.c | 10 ++++------ > drivers/media/platform/renesas/vsp1/vsp1_drv.c | 14 +++++++------- > 5 files changed, 24 insertions(+), 28 deletions(-) -- Regards, Laurent Pinchart
