On Wed, Jul 09, 2025 at 09:16:07PM +0200, Geert Uytterhoeven wrote:
> Convert the Renesas Digital Radio Interface driver from
> SIMPLE_DEV_PM_OPS() to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr().
> This lets us drop the __maybe_unused annotations from its suspend and
> resume callbacks, and reduces kernel size in case CONFIG_PM or
> CONFIG_PM_SLEEP is disabled.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> drivers/media/platform/renesas/rcar_drif.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index fc8b6bbef793c64e..0f0c5844e22ea86c 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -1446,18 +1446,18 @@ static void rcar_drif_remove(struct platform_device *pdev)
> }
>
> /* FIXME: Implement suspend/resume support */
> -static int __maybe_unused rcar_drif_suspend(struct device *dev)
> +static int rcar_drif_suspend(struct device *dev)
> {
> return 0;
> }
>
> -static int __maybe_unused rcar_drif_resume(struct device *dev)
> +static int rcar_drif_resume(struct device *dev)
> {
> return 0;
> }
>
> -static SIMPLE_DEV_PM_OPS(rcar_drif_pm_ops, rcar_drif_suspend,
> - rcar_drif_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_drif_pm_ops, rcar_drif_suspend,
> + rcar_drif_resume);
>
> static const struct of_device_id rcar_drif_of_table[] = {
> { .compatible = "renesas,rcar-gen3-drif" },
> @@ -1470,7 +1470,7 @@ static struct platform_driver rcar_drif_driver = {
> .driver = {
> .name = RCAR_DRIF_DRV_NAME,
> .of_match_table = rcar_drif_of_table,
> - .pm = &rcar_drif_pm_ops,
> + .pm = pm_sleep_ptr(&rcar_drif_pm_ops),
> },
While at it, let's fix the indentation issue here. I can do so when
applying, no need to resend just for this.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> .probe = rcar_drif_probe,
> .remove = rcar_drif_remove,
--
Regards,
Laurent Pinchart
