Hi Geert,
Thanks for your patch.
On 2025-07-09 21:04:58 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas R-Car Gen3 thermal driver from SIMPLE_DEV_PM_OPS()
> to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr(). This lets us drop the
> __maybe_unused annotation from its resume callback, and reduces kernel
> size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/thermal/renesas/rcar_gen3_thermal.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/renesas/rcar_gen3_thermal.c b/drivers/thermal/renesas/rcar_gen3_thermal.c
> index 24a702ee4c1fb83d..b54338bbc4c78a1d 100644
> --- a/drivers/thermal/renesas/rcar_gen3_thermal.c
> +++ b/drivers/thermal/renesas/rcar_gen3_thermal.c
> @@ -570,7 +570,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int __maybe_unused rcar_gen3_thermal_resume(struct device *dev)
> +static int rcar_gen3_thermal_resume(struct device *dev)
> {
> struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
> unsigned int i;
> @@ -584,13 +584,13 @@ static int __maybe_unused rcar_gen3_thermal_resume(struct device *dev)
> return 0;
> }
>
> -static SIMPLE_DEV_PM_OPS(rcar_gen3_thermal_pm_ops, NULL,
> - rcar_gen3_thermal_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_gen3_thermal_pm_ops, NULL,
> + rcar_gen3_thermal_resume);
>
> static struct platform_driver rcar_gen3_thermal_driver = {
> .driver = {
> .name = "rcar_gen3_thermal",
> - .pm = &rcar_gen3_thermal_pm_ops,
> + .pm = pm_sleep_ptr(&rcar_gen3_thermal_pm_ops),
> .of_match_table = rcar_gen3_thermal_dt_ids,
> },
> .probe = rcar_gen3_thermal_probe,
> --
> 2.43.0
>
--
Kind Regards,
Niklas Söderlund
