Hi Geert,
Thanks for your work.
On 2025-07-09 20:43:59 +0200, Geert Uytterhoeven wrote:
> Convert the Renesas R-Car GPIO driver from SIMPLE_DEV_PM_OPS() to
> DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr(). This lets us drop the
> check for CONFIG_PM_SLEEP, and reduces kernel size in case CONFIG_PM or
> CONFIG_PM_SLEEP is disabled, while increasing build coverage.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-rcar.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 1d121a4275905e09..cd31580effa9037f 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -592,7 +592,6 @@ static void gpio_rcar_remove(struct platform_device *pdev)
> pm_runtime_disable(&pdev->dev);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> static int gpio_rcar_suspend(struct device *dev)
> {
> struct gpio_rcar_priv *p = dev_get_drvdata(dev);
> @@ -651,16 +650,16 @@ static int gpio_rcar_resume(struct device *dev)
>
> return 0;
> }
> -#endif /* CONFIG_PM_SLEEP*/
>
> -static SIMPLE_DEV_PM_OPS(gpio_rcar_pm_ops, gpio_rcar_suspend, gpio_rcar_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(gpio_rcar_pm_ops, gpio_rcar_suspend,
> + gpio_rcar_resume);
>
> static struct platform_driver gpio_rcar_device_driver = {
> .probe = gpio_rcar_probe,
> .remove = gpio_rcar_remove,
> .driver = {
> .name = "gpio_rcar",
> - .pm = &gpio_rcar_pm_ops,
> + .pm = pm_sleep_ptr(&gpio_rcar_pm_ops),
> .of_match_table = gpio_rcar_of_table,
> }
> };
> --
> 2.43.0
>
>
--
Kind Regards,
Niklas Söderlund
