Hi Geert,
On 2025-07-07 13:47:32 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Fri, 4 Jul 2025 at 12:08, Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > Add an overlay to connect an IMX219 camera sensor to the J1 connector.
> > The IMX219 utilizes 2 CSI-2 D-PHY lanes. This enables the video capture
> > pipeline behind the CSI40 Rx to be enabled to process images from the
> > sensor.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> Thanks for your patch!
Thanks for your review.
>
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk-camera-j1-imx219.dtso
>
> > +/* Page 29 / CSI_IF_CN */
> > +&csi40 {
> > + status = "okay";
> > +
> > + ports {
> > + port {
>
> The base arch/arm64/boot/dts/renesas/r8a779g0.dtsi has "port@0".
Indeed, this should be port@, will fix.
> Still, this is applied to the correct node?
As far as I can tell it did, and the cameras worked as expected.
>
> $ dtx_diff --color
> arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk{,-camera-j1-imx219}.dtb
> [...]
>
> port@0 {
> reg = <0x00>;
> +
> + endpoint {
> + bus-type = <0x04>;
> + clock-lanes = <0x00>;
> + data-lanes = <0x01 0x02>;
> + phandle = <0xf2>;
> + remote-endpoint = <0xf3>;
> + };
> };
>
> port@1 {
> [...]
>
> > + csi40_in: endpoint {
> > + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> > + clock-lanes = <0>;
> > + data-lanes = <1 2>;
> > + remote-endpoint = <&imx219_j1_out>;
> > + };
> > + };
> > + };
> > +};
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
