Re: [PATCH 4/6] ARM: dts: renesas: genmai: add rpc-if SPI NOR flash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Magnus,

On Sat, 5 Jul 2025 at 21:09, Magnus Damm <damm@xxxxxxxxxxxxx> wrote:
> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>
> Add genmai board support code to make use of one of the on-chip rpc-if devices
> to interface to the on-board SPI flash U6 Spansion S25FK512S-16. Without this
> patch the SPI flash is accessible through a memory mapped window, however by
> adding pinctrl configuration and a rpc-if device node to the DTS we can now
> access the SPI flash via the the rpc-if driver instead.
>
> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>

Thanks for your patch!

> --- 0001/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ work/arch/arm/boot/dts/renesas/r7s72100-genmai.dts  2025-07-06 00:02:33.267119292 +0900
> @@ -18,6 +18,7 @@
>
>         aliases {
>                 serial0 = &scif2;
> +               spi0 = &rpc0;

I don't think you need this/

>         };
>
>         chosen {
> @@ -25,35 +26,6 @@
>                 stdout-path = "serial0:115200n8";
>         };
>
> -       flash@18000000 {
> -               compatible = "mtd-rom";
> -               reg = <0x18000000 0x08000000>;
> -               bank-width = <4>;
> -               device-width = <1>;
> -
> -               clocks = <&mstp9_clks R7S72100_CLK_SPIBSC0>;
> -               power-domains = <&cpg_clocks>;
> -
> -               #address-cells = <1>;
> -               #size-cells = <1>;
> -
> -               partitions {
> -                       compatible = "fixed-partitions";
> -                       #address-cells = <1>;
> -                       #size-cells = <1>;
> -
> -                       partition@0 {
> -                               label = "user";
> -                               reg = <0x00000000 0x04000000>;
> -                       };
> -
> -                       partition@4000000 {
> -                               label = "user1";
> -                               reg = <0x04000000 0x04000000>;
> -                       };
> -               };
> -       };
> -

Removing this breaks the direct-mapped FLASH ROM, which may affect
userspace, and prevents using XIP (but I understand no one cares about
the latter anymore).

>         keyboard {
>                 compatible = "gpio-keys";
>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux