> > Are these actually needed? It seems like they could be local functions. > > Currently is_rdev() is only used in rswitch_l2.c. I moved it to that file and made it static. In the > future it will also be used in the L3 routing. The function rswitch_modify() is used in rswitch_main.c > and rswitch_l2.c I believe in this case it does make sense to have a single implementation. Or should > I use two local copies? Have long do you think it will be before L3 is added? If you have the code ready and waiting, then please keep it driver global. If it is going to be a while before L3 is added, i would add it to rswitch_l2.c, and move it to a common file when you add rswitch_l3.c Andrew
